[PATCH] D111208: [clang-tidy] Support globbing in NOLINT* expressions

[Aaron Ballman via Phabricator via llvm-commits]

aaron.ballman added a comment.

In D111208#3073144 <https://reviews.llvm.org/D111208#3073144>, @carlosgalvezp wrote:

> Actually, `cpplint` is never compatible with `clang-tidy` regardless. The following code:
>
>   struct Foo
>   {
>   	Foo(int) {} // NOLINT(google-explicit-constructor)
>   };
>
> Triggers:
>
>   ../test.cpp:3:  Unknown NOLINT error category: google-explicit-constructor  [readability/nolint] [5]
>
> So one has to disable the diagnostic anyway via `--filter=-readability/nolint`. I've tested using globs and cpplint works fine so long the diagnostic is suppressed. I.e. this patch doesn't change things in that respect.
>
> I go ahead and merge if you are happy then!

Oh, that's a bummer. :-( Oh well, your patch doesn't make that any worse.

In D111208#3073160 <https://reviews.llvm.org/D111208#3073160>, @carlosgalvezp wrote:

> A bit annoying about the build bot, fixed in a separate commit. Do you know if we can run these jobs pre-pushing? Seems rather unlikely to have them all pass the first time, especially for larger commits...

Unfortunately, precommit CI is pretty limited and extremely flakey, so the only real way to know right now is to push and see how the bot farm likes it. (There are a lot of bots we don't want to use for precommit CI because they take a long time to run, use experimental or flakey hardware, etc.)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111208/new/

https://reviews.llvm.org/D111208