[PATCH] D112054: [LV] Pre-commit test for D111846

Florian Hahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 19 08:33:36 PDT 2021


fhahn accepted this revision.
fhahn added a comment.
This revision is now accepted and ready to land.

LGTM, thanks!



================
Comment at: llvm/test/Transforms/LoopVectorize/X86/pr52111.ll:119
+  %i29 = getelementptr inbounds float, float* %input, i64 %i26
+  %i30 = load float, float* %i29, align 4, !invariant.load !0, !noalias !1
+  br label %if.end
----------------
`!noalias` should not be needed, as `%input` already has `noalias`.


================
Comment at: llvm/test/Transforms/LoopVectorize/X86/pr52111.ll:125
+  %i35 = getelementptr inbounds float, float* %output, i64 %iv
+  store float %i34, float* %i35, align 4, !alias.scope !1
+  %iv.inc = add nuw nsw i64 %iv, 1
----------------
`alias.scope` should not be added as `%input` is `noalias`.


================
Comment at: llvm/test/Transforms/LoopVectorize/X86/pr52111.ll:136
+
+!0 = !{}
+!1 = !{!2}
----------------
Only this seems to be needed, the other metadata can be dropped.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112054/new/

https://reviews.llvm.org/D112054



More information about the llvm-commits mailing list