[PATCH] D111706: [lld-macho] Fix dangling string reference when adding frameworks

[Vy Nguyen via Phabricator via llvm-commits]

oontvoo accepted this revision as: oontvoo.
oontvoo added a comment.

LGTM - thanks!
(leaving the lld-macho checkbox for int3, in case he has additional comments ... otherwise, I can check it EOD)



================
Comment at: lld/test/MachO/lc-linker-option.ll:50
 ; INVALID: error: -why_load is not allowed in LC_LINKER_OPTION
 
+; RUN: llc %t/foo.ll -o %t/foo.o -filetype=obj
----------------
Include a comment here explaining what/why we're testing this (since this isn't testing linker option per se)?
(perhaps include reference to either the bug or this patch)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111706/new/

https://reviews.llvm.org/D111706