[PATCH] D111433: [PowerPC] Respect rounding mode in the back end

Tue Oct 19 05:54:35 PDT 2021

qiucf accepted this revision as: qiucf.
qiucf added inline comments.

================
Comment at: llvm/lib/Target/PowerPC/PPCISelLowering.cpp:5228
+    RetOpc = PPCISD::CALL;
+  if (IsStrictFPCall) {
+    switch (RetOpc) {
----------------
nemanjai wrote:
> nemanjai wrote:
> > qiucf wrote:
> > > Better to move this into a static function?
> > I don't have a particularly strong opinion on this since we are already in a static function and the code would read exactly the same. I already separated it into code that computes the node to use and then code that updates the opcode for strictfp, so it can very easily be two separate functions.
> > 
> > If you have a preference for moving it out, please let me know and I'll update it.
> @qiucf I am waiting to hear from you whether you insist on this change or if you're OK with my rationale above.
Ah sorry. I meant to have no objections. This looks good to me. Thanks!

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111433/new/

https://reviews.llvm.org/D111433