[PATCH] D111668: [LoopPredication] Calculate profitability without BPI

Tue Oct 19 05:46:25 PDT 2021

anna added a comment.

In D111668#3071306 <https://reviews.llvm.org/D111668#3071306>, @asbirlea wrote:

> Looks reasonable, assuming you're seeing similar results to using BPI. I'm not very familiar with BPI itself, so if others reviewers are, I'll let them chime in.
>
> Does it make sense to make `isValidProfileData` and `ComputeBranchProbability` static utilities in `BranchProbability`? (nit: consistent case-ing on the names)

I think that's a good idea. Will do as a follow-up after landing patch.

Will fix the naming.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111668/new/

https://reviews.llvm.org/D111668