[PATCH] D111727: [DSE] Eliminates dead store of an exisiting value (PR16520)

[Roman Lebedev via Phabricator via llvm-commits]

lebedev.ri added a comment.

https://reviews.llvm.org/D90328#2428525

In D111727#3069380 <https://reviews.llvm.org/D111727#3069380>, @yurai007 wrote:

> In D111727#3061936 <https://reviews.llvm.org/D111727#3061936>, @lebedev.ri wrote:
>
>> All comments from the original review still apply.
>
> Do you have something specific in mind? It looks like all comments from old review are done (even if not marked as "fixed" which is quite confusing) except one from Nikita addressed in this change.



In D90328#2428525 <https://reviews.llvm.org/D90328#2428525>, @lebedev.ri wrote:

> Terminology check: the store being eliminated isn't so much dead,
> it's that the stored value is identical to the currently-stored value,
> i.e. the store is effectively a no-op.



In D90328#2432235 <https://reviews.llvm.org/D90328#2432235>, @fhahn wrote:

> In D90328#2428525 <https://reviews.llvm.org/D90328#2428525>, @lebedev.ri wrote:
>
>> Terminology check: the store being eliminated isn't so much dead,
>> it's that the stored value is identical to the currently-stored value,
>> i.e. the store is effectively a no-op.
>
> Yep, it would be better to refer to redundant or no-op stores.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111727/new/

https://reviews.llvm.org/D111727