[PATCH] D111706: [lld-macho] Fix dangling string reference when adding frameworks

Kaining Zhong via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 19 00:37:39 PDT 2021


PRESIDENT810 updated this revision to Diff 380595.
PRESIDENT810 added a comment.

Hello.

I rewrote my test using llvm IR, and add it to the lc-linker-option.ll test. I also add "saver.save()" wherever a function calls resolveDylibPath without saving the string itself, and removed saving StringRef instance in DriverUtils.cpp:line 199.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111706/new/

https://reviews.llvm.org/D111706

Files:
  lld/MachO/Driver.cpp
  lld/MachO/Driver.h
  lld/MachO/DriverUtils.cpp
  lld/MachO/InputFiles.cpp
  lld/test/MachO/lc-linker-option.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D111706.380595.patch
Type: text/x-patch
Size: 10526 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20211019/0619e29b/attachment.bin>


More information about the llvm-commits mailing list