[PATCH] D111966: [llvm-readobj] Add support for reading OpenBSD ELF core notes.

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: llvm/include/llvm/BinaryFormat/ELF.h:1614
+};
+
+
----------------
one blank line


================
Comment at: llvm/tools/llvm-readobj/ELFDumper.cpp:5334
 
+static const NoteType OpenBSDCoreNoteTypes[] = {
+    {ELF::NT_OPENBSD_PROCINFO, "NT_OPENBSD_PROCINFO (procinfo structure)"},
----------------
By default a non-template variable of non-volatile const-qualified type belong to a namespace scope is internal, so `static const` can usually be written as `const`.

I simplified other variables.


================
Comment at: llvm/tools/llvm-readobj/ELFDumper.cpp:5454
   }
+  if (Name.find("OpenBSD") != StringRef::npos) {
+    if (ELFType == ELF::ET_CORE) {
----------------
`startswith("OpenBSD")` If I understand it correctly


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111966/new/

https://reviews.llvm.org/D111966