[PATCH] D111896: [indvars] Canonicalize exit conditions to unsigned using range info

[Max Kazantsev via Phabricator via llvm-commits]

mkazantsev accepted this revision.
mkazantsev added a comment.
This revision is now accepted and ready to land.

Looks fine now, thanks! Suggestion for follow-up in comments.



================
Comment at: llvm/lib/Transforms/Scalar/IndVarSimplify.cpp:1441
+  if (!L->isLoopInvariant(RHS))
+    return false;
+
----------------
Can we end up with non-canonicalized comparison here? I.e. LHS is invariant and RHS is not. If so, we can swap them. OK if done in follow-up.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111896/new/

https://reviews.llvm.org/D111896