[PATCH] D88741: [SystemZ/z/OS] Add utility class for char set conversion.

[Hubert Tong via Phabricator via llvm-commits]

hubert.reinterpretcast added a comment.

I've looked at the new changes and verified that the recent updates are an improvement. There remain unaddressed comments.



================
Comment at: llvm/include/llvm/Support/CharSet.h:32
+namespace text_encoding {
+enum class id {
+  /// UTF-8 character set encoding.
----------------
ZarkoCA wrote:
> I think enums should start with an uppercase letter as per the style guide.
Thanks @ZarkoCA. The coding standards don't state this, but the existing practice is that the exception (from the coding standards) about following the C++ STL naming convention in some cases is more broadly applicable for components with a corresponding standard (or proposed standard) facility like this one.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88741/new/

https://reviews.llvm.org/D88741