[PATCH] D111770: [DebugInfo] When the enum type causes ODR violation, skip ODRUniquing

Yuanfang Chen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 18 15:05:47 PDT 2021


ychen marked 2 inline comments as done.
ychen added inline comments.


================
Comment at: llvm/test/Linker/debug-info-bad-enum.ll:4
+
+; CHECK-NOT: enum type is not a scope; check enum type ODR violation
+
----------------
dblaikie wrote:
> Probably also check that the resulting IR is good/correct? Like that the first CU has a reference to the enumeration type from the enum list, and the second CU has a reference to the structure_type from the retained types list?
Yep.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111770/new/

https://reviews.llvm.org/D111770



More information about the llvm-commits mailing list