[PATCH] D111930: Add support for Bazel builds on Windows with `clang-cl`.

[Geoffrey Martin-Noble via Phabricator via llvm-commits]

GMNGeoffrey added inline comments.


================
Comment at: utils/bazel/llvm-project-overlay/clang/BUILD.bazel:32
     ],
-    linkopts = ["-ldl"],
+    linkopts = select({
+        "@bazel_tools//src/conditions:windows": [],
----------------
Is it actually these files that need dl? Previously we decided it was better to add it the root library that used it. We're already setting it in `llvm:Support`, which this depends on, so I don't think this should be necessary (https://github.com/llvm/llvm-project/blob/0eed292fbae22a8856682b07e1cb968424b49941/utils/bazel/llvm-project-overlay/llvm/BUILD.bazel#L211)


================
Comment at: utils/bazel/llvm-project-overlay/llvm/unittests/BUILD.bazel:115
     name = "codegen_tests",
-    size = "small",
+    size = "medium",
     srcs = glob(
----------------
Hmmm unfortunate that these have to increase specifically for windows. Do windows tests take longer overall? We could change the actual timeouts corresponding to the timeout names instead.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111930/new/

https://reviews.llvm.org/D111930