[PATCH] D111970: [GlobalISel][Legalizer] Restore eraseFromParentAndMarkDBGValuesForRemoval() for CallLowering artifacts.

Amara Emerson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 18 14:28:01 PDT 2021


aemerson added a comment.

Please see the discussion here: https://groups.google.com/g/llvm-dev/c/R9lSoAqh5e4

The summary is that this isn't technically incorrect. We can address your test case either by fixing the assert in the instruction selector to not care if the vreg being checked is only used by DBG_VALUE instructions, or we can do it by having a pass over all the VRegs after the legalizer runs. If we go for the second, we might as well always use `eraseFromParent()` anyway.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111970/new/

https://reviews.llvm.org/D111970



More information about the llvm-commits mailing list