[PATCH] D111875: [Support] [Windows] Manually clean up temp files on network shares

Mon Oct 18 13:58:05 PDT 2021

rnk added a comment.

In D111875#3071392 <https://reviews.llvm.org/D111875#3071392>, @mstorsjo wrote:

> Well there's a couple uses in `TempFile::keep()` too. Then again, with a bit more changes, we could stop calling them too, if we aren't using the delete disposition for this file altogether.

The `RemoveOnClose` boolean seems like it could work there, though. It essentially tracks, "do I need to delete manually, or will the OS take care of it for me". Maybe I misunderstood and it isn't quite that.

Anyway, thanks for giving it a try.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111875/new/

https://reviews.llvm.org/D111875