[PATCH] D111770: [DebugInfo] When the enum type causes ODR violation, skip ODRUniquing
David Blaikie via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Oct 18 13:21:00 PDT 2021
dblaikie added a comment.
This generally looks good to me - but I'd like @aprantl or similar to take a look/sign off from an "debug info verifier/invariants" perspective.
================
Comment at: llvm/test/Linker/debug-info-bad-enum.ll:4
+
+; CHECK-NOT: enum type is not a scope; check enum type ODR violation
+
----------------
Probably also check that the resulting IR is good/correct? Like that the first CU has a reference to the enumeration type from the enum list, and the second CU has a reference to the structure_type from the retained types list?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D111770/new/
https://reviews.llvm.org/D111770
More information about the llvm-commits
mailing list