[PATCH] D111668: [LoopPredication] Calculate profitability without BPI

Alina Sbirlea via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 18 13:07:15 PDT 2021


asbirlea added a comment.

Looks reasonable, assuming you're seeing similar results to using BPI. I'm not very familiar with BPI itself, so if others reviewers are, I'll let them chime in.

Does it make sense to make `isValidProfileData` and `ComputeBranchProbability` static utilities in `BranchProbability`? (nit: consistent case-ing on the names)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111668/new/

https://reviews.llvm.org/D111668



More information about the llvm-commits mailing list