[PATCH] D111448: [BPI] Handle incomplete state in BPI

[Alina Sbirlea via Phabricator via llvm-commits]

asbirlea accepted this revision.
asbirlea added a comment.
This revision is now accepted and ready to land.

The question I was trying to get answer was: can there be the case where the probability is queried such that you can get different values based on when (what order) the blocks are removed or added? I think the answer is no, and I *think* I know why you're sometimes *not* triggering the assert: it's when `IndexInSuccessors == 0`. I suspect the successor order at the callsite in `LoopPredication.cpp:947` is non-deterministic, so sometimes it's comparing against index 1, which does not have prob, and sometimes against itself, for which it does.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111448/new/

https://reviews.llvm.org/D111448