[PATCH] D111926: [libc++][doc] Use sphinx variables to make updating the docs version easier

Mon Oct 18 11:21:10 PDT 2021

ldionne added a comment.

The intent of the change looks good to me, i.e. using variables to set the version number & al.

However, I checked out this patch and built the documentation, and it doesn't show "In Progress" anymore, nor does it have any mention of being the libc++ 14.0.0 incoming release. Is that intended? IMO, it was useful to have that visual marker about notes being in-progress release notes for an upcoming release.

If that's not intended, then I assume this is most likely caused by a difference in how we run our builds. What I'm using is:

  $ git clone https://github.com/llvm/llvm-project.git
  $ cd llvm-project
  $ mkdir build
  $ cmake -G Ninja -S runtimes -B build -DLLVM_ENABLE_RUNTIMES="libcxx;libcxxabi;libunwind" -DLLVM_ENABLE_SPHINX=ON
  $ ninja -C build docs-libcxx-html

================
Comment at: libcxx/docs/Makefile.sphinx:1
-# Makefile for Sphinx documentation
-#
----------------
This is fine - I don't think there's any desire to keep this around, at least not from my side.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111926/new/

https://reviews.llvm.org/D111926