[PATCH] D111575: [NewPM] Add PipelineTuningOption to eagerly invalidate analyses

Nikita Popov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 18 10:58:04 PDT 2021


nikic added inline comments.


================
Comment at: llvm/include/llvm/Passes/PassBuilder.h:80
+  /// due to either passes using analyses only when cached, or invalidating and
+  /// recalculating an analysis that was stale/imprecise but still valid.
+  bool EagerlyInvalidateAnalyses;
----------------
I think this could be more precise about what "invalidate more analyses" means. From the implementation, my understanding is that analyses will be invalidated after a function pass manager finishes processing a function.

Makes me wonder if we shouldn't be handling this in the Function to CGSCC/Module pass manager adaptors.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111575/new/

https://reviews.llvm.org/D111575



More information about the llvm-commits mailing list