[PATCH] D111397: Add new MachineFunction property FailsVerification

[Jay Foad via Phabricator via llvm-commits]

foad added inline comments.


================
Comment at: llvm/include/llvm/CodeGen/MIRYamlMapping.h:726
     YamlIO.mapOptional("hasWinCFI", MF.HasWinCFI, false);
+    YamlIO.mapOptional("failsVerification", MF.FailsVerification, false);
     YamlIO.mapOptional("registers", MF.VirtualRegisters,
----------------
arsenm wrote:
> This should not need explicit serialization. The verifier runs after mir parsing anyway. 
> 
> It should also be illegal to clear this after it’s set 
> This should not need explicit serialization.

Why? It means "this function has known problems that I haven't fixed yet so please don't run the verifier on it".

> It should also be illegal to clear this after it’s set

Why?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111397/new/

https://reviews.llvm.org/D111397