[llvm] 51788a5 - [JITLink][NFC] Fix Wdangling-else warning in LinkGraphTests

Ben Langmuir via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 18 10:07:37 PDT 2021


Author: Ben Langmuir
Date: 2021-10-18T10:06:55-07:00
New Revision: 51788a5aff870a8e87ce34ffa6cecb46ce68f72e

URL: https://github.com/llvm/llvm-project/commit/51788a5aff870a8e87ce34ffa6cecb46ce68f72e
DIFF: https://github.com/llvm/llvm-project/commit/51788a5aff870a8e87ce34ffa6cecb46ce68f72e.diff

LOG: [JITLink][NFC] Fix Wdangling-else warning in LinkGraphTests

Fix a dangling else that gcc-11 warned about. The EXPECT_EQ macro
expands to an if-else, so the whole construction contains a hidden
hangling else.

Added: 
    

Modified: 
    llvm/unittests/ExecutionEngine/JITLink/LinkGraphTests.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/unittests/ExecutionEngine/JITLink/LinkGraphTests.cpp b/llvm/unittests/ExecutionEngine/JITLink/LinkGraphTests.cpp
index 964bef5991780..c8958e4d9f3b8 100644
--- a/llvm/unittests/ExecutionEngine/JITLink/LinkGraphTests.cpp
+++ b/llvm/unittests/ExecutionEngine/JITLink/LinkGraphTests.cpp
@@ -345,8 +345,9 @@ TEST(LinkGraphTest, TransferDefinedSymbolAcrossSections) {
 
   EXPECT_EQ(Sec1.symbols_size(), 0u) << "Symbol was not removed from Sec1";
   EXPECT_EQ(Sec2.symbols_size(), 1u) << "Symbol was not added to Sec2";
-  if (Sec2.symbols_size() == 1)
+  if (Sec2.symbols_size() == 1) {
     EXPECT_EQ(*Sec2.symbols().begin(), &S1) << "Unexpected symbol";
+  }
 }
 
 TEST(LinkGraphTest, TransferBlock) {


        


More information about the llvm-commits mailing list