[PATCH] D109652: [PowerPC] Restrict various P10 options to P10 only.

[Lei Huang via Phabricator via llvm-commits]

lei accepted this revision.
lei added a comment.

LGTM
I think you went a bit overkill with the tests for this patch 🙂.  Please cut down the number of run lines before committing.



================
Comment at: clang/test/Driver/ppc-p10-features-support-check.c:4
+// RUN:   --check-prefix=HASPAIRED
+// RUN: %clang -target powerpc64le-unknown-linux-gnu -S -emit-llvm  \
+// RUN:   -mcpu=power10 -mpaired-vector-memops %s -o - | FileCheck %s \
----------------
I think you can just use `pwr10` and `power10` in diff run lines if you need, but no need to test for both in this case.


================
Comment at: clang/test/Driver/ppc-p10-features-support-check.c:11
+// RUN: not %clang -target powerpc64le-unknown-linux-gnu -fsyntax-only \
+// RUN:   -mcpu=pwr8 -mpaired-vector-memops %s 2>&1 | FileCheck %s \
+// RUN:   --check-prefix=NOPAIRED
----------------
might be an overkill to also test for pwr7/8.  I think pwr9/10 test is enough.


================
Comment at: clang/test/Driver/ppc-p10-features-support-check.c:19
+// RUN:   --check-prefix=NOPAIRED
+
+// RUN: %clang -target powerpc64le-unknown-linux-gnu -S -emit-llvm  \
----------------
same comment for the set of runlines below.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109652/new/

https://reviews.llvm.org/D109652