[PATCH] D108507: [NFC][LoopIdiom] Add more test case to runtime-determined memset size

Bardia Mahjour via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 18 07:41:52 PDT 2021


bmahjour added inline comments.


================
Comment at: llvm/test/Transforms/LoopIdiom/memset-runtime-32bit.ll:99
+}
+; void NestedFor32(int *ar, int n, int m, int o)
+; {
----------------
match the order of arguments with the actual function.


================
Comment at: llvm/test/Transforms/LoopIdiom/memset-runtime-32bit.ll:176
+; }
+define void @PositiveFor64(i32* %ar, i64 %n, i64 %m) {
+; CHECK-LABEL: @PositiveFor64(
----------------
The tests from here look very similar to the ones in memset-runtime-64bit.ll. I'd suggest using `int i` instead of `long long i` (or add at least one test where the loop upper bound is 8 bytes and the induction variable is 4 bytes).


================
Comment at: llvm/test/Transforms/LoopIdiom/memset-runtime-32bit.ll:268
+}
+; void NestedFor64(long long n, long long m, long long o, int *ar)
+; {
----------------
match order of arguments with the actual function


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108507/new/

https://reviews.llvm.org/D108507



More information about the llvm-commits mailing list