[PATCH] D110514: MIPS: Triple::setArch as R6 if MipsSubArch_r6

YunQiang Su via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 18 07:15:37 PDT 2021


wzssyqa marked an inline comment as done.
wzssyqa added inline comments.


================
Comment at: llvm/lib/Support/Triple.cpp:1432
+  case Triple::mips64:
+    T.setArch(Triple::mips, getSubArch());
+    break;
----------------
arichardson wrote:
> Shouldn't all others also preserve the subarch?
As I know, there are no other architectures need subarch here.
So, I think that it is better to keep it as now.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110514/new/

https://reviews.llvm.org/D110514



More information about the llvm-commits mailing list