[PATCH] D111460: [X86][LoopVectorize] "Fix" `X86TTIImpl::getAddressComputationCost()`
Dave Green via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Oct 18 07:13:03 PDT 2021
dmgreen added inline comments.
================
Comment at: llvm/lib/Transforms/Vectorize/LoopVectorize.cpp:7061
Type *PtrTy = ToVectorTy(Ptr->getType(), VF);
+ // FIXME: PtrTy should not be a vector, it's a hack.
----------------
pengfei wrote:
> lebedev.ri wrote:
> > pengfei wrote:
> > > It would be more productive if it includes the reason why we can’t change it right away.
> > > Lack of such explanation led to the original version of the patch that repeats D93129.
> > I'm open to suggestions as to how this should be amended.
> Sorry, I don't have a concrete suggestion. I have concerns because I saw disagreement from Dave and didn't see consensus have been made.
My comments were mostly for ARM/AArch64, which this patch no longer affects. I don't have as much knowledge on X86 matters and no evidence suggesting one way or another whether this is a good idea I'm afraid.
I don't think this comment is particularly useful though. Personally I would personally just remove this comment and leave the patch to the X86 backend.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D111460/new/
https://reviews.llvm.org/D111460
More information about the llvm-commits
mailing list