[PATCH] D111227: [WebAssembly] Implementation of table.grow/size and ref.null intrinsics

Mon Oct 18 06:14:47 PDT 2021

pmatos added a comment.

In D111227#3070024 <https://reviews.llvm.org/D111227#3070024>, @pmatos wrote:

> In D111227#3069965 <https://reviews.llvm.org/D111227#3069965>, @pmatos wrote:
>
>> That makes sense. Thanks for the pointers. 
>> I am sort of going the rabbit hole of trying to understand how far I need to go to have `llvm_externref_ty` and `llvm_funcref_ty` in an intrinsic. This seems to require changes in a wide range of files - assuming it would be similar (if not worse) with a polymorphic type. Unfortunately, it is still now compiling as there are further changes required.
>
> This feels like going into the rabbit hole of adding a new type as mentioned in https://www.llvm.org/docs/ExtendingLLVM.html#adding-a-new-type
> Unsure this is necessary, but it feels like it might be if we need to specify a reference type for the intrinsic. On the other hand it's not great as I am starting to touch things related to bc encoding for the new ref types.

I keep thinking that we should be able to model these as pointers to something instead of new types, however the `llvm_ptr_ty` doesn't seem to allow specifying the pointee type. I will continue an investigation in this direction.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111227/new/

https://reviews.llvm.org/D111227