[PATCH] D111988: [Dexter] Add DexFinishTest command to conditionally early-exit a test program

Stephen Tozer via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 18 05:08:16 PDT 2021


StephenTozer created this revision.
StephenTozer added reviewers: TWeaver, jmorse, Orlando, chrisjackson.
StephenTozer added a project: debug-info.
StephenTozer requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

Some programs to be tested by Dexter have inconvenient termination conditions, either terminating long after all test commands have been exhausted or never self-terminating at all. This can be fixed by editing the test source to add a new exit condition(s), but doing so may affect debug info, and the "correct" place to exit may be different across different tests for the same program.

This patch adds a command, DexFinishTest, that allows a Dexter test to be conditionally finished at a given breakpoint. This command has the same set of arguments as DexLimitSteps, except that it does not allow a line range (from_line, to_line), only a single line (on_line). When it is triggered the debugger is closed and the test is finished - this does not affect the scoring in Dexter, except in that no further step information will be gathered.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D111988

Files:
  cross-project-tests/debuginfo-tests/dexter/Commands.md
  cross-project-tests/debuginfo-tests/dexter/dex/command/ParseCommand.py
  cross-project-tests/debuginfo-tests/dexter/dex/command/commands/DexFinishTest.py
  cross-project-tests/debuginfo-tests/dexter/dex/debugger/DebuggerControllers/ConditionalController.py
  cross-project-tests/debuginfo-tests/dexter/dex/debugger/DebuggerControllers/DefaultController.py
  cross-project-tests/debuginfo-tests/dexter/feature_tests/commands/perfect/dex_finish_test/default_conditional.cpp
  cross-project-tests/debuginfo-tests/dexter/feature_tests/commands/perfect/dex_finish_test/default_conditional_hit_count.cpp
  cross-project-tests/debuginfo-tests/dexter/feature_tests/commands/perfect/dex_finish_test/default_hit_count.cpp
  cross-project-tests/debuginfo-tests/dexter/feature_tests/commands/perfect/dex_finish_test/default_simple.cpp
  cross-project-tests/debuginfo-tests/dexter/feature_tests/commands/perfect/dex_finish_test/limit_steps_conditional.cpp
  cross-project-tests/debuginfo-tests/dexter/feature_tests/commands/perfect/dex_finish_test/limit_steps_conditional_hit_count.cpp
  cross-project-tests/debuginfo-tests/dexter/feature_tests/commands/perfect/dex_finish_test/limit_steps_hit_count.cpp
  cross-project-tests/debuginfo-tests/dexter/feature_tests/commands/perfect/dex_finish_test/limit_steps_simple.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D111988.380350.patch
Type: text/x-patch
Size: 19279 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20211018/7a57c5e3/attachment.bin>


More information about the llvm-commits mailing list