[PATCH] D111715: [WIP] [lldb] change name demangling to be consistent between windows and linx

[Raphael Isemann via Phabricator via llvm-commits]

teemperor added a comment.

In D111715#3068412 <https://reviews.llvm.org/D111715#3068412>, @thakis wrote:

> I don't have an opinion on this change and I don't mind the demangler change, but isn't the type information helpful? The mangled itanium name doesn't include type information which is why it's not printed, but the mangled ms name does include it.
>
> But as I said, I don't have an opinion either way.

I think the motivation for this patch is just that LLDB uses the demangler to determine variable names and with the current MS demangler, the variable names returned by LLDB are for example `int (*array2d)[10]` on Windows instead of `array2d` (on platforms that use the itanium demangler). And that's clearly not what any user expects when they ask for the name of a variable behind a symbol. Note that type information in LLDB is a separate part of the information, so having the type information in the name gives the user no additional information.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111715/new/

https://reviews.llvm.org/D111715