[PATCH] D111397: Add new MachineFunction property FailsVerification

Mon Oct 18 02:36:32 PDT 2021

foad added inline comments.

================
Comment at: llvm/lib/Target/AMDGPU/AMDILCFGStructurizer.cpp:130
   bool runOnMachineFunction(MachineFunction &MF) override {
+    // FIXME: This pass causes verification failures.
+    MF.getProperties().reset(MachineFunctionProperties::Property::Verifies);
----------------
foad wrote:
> MatzeB wrote:
> > So, there's this thing I've seen other projects do, where they file tickets in the bugtracker and reference those in code. I know we don't usually do this in LLVM yet, but maybe we can set a new precedent here, what do you think?
> I'm happy to do this in principle.
Done for the AMDGPU SILowerControlFlow case: a129932b0d45949a884cee90726bf90217c2e737
For the Hexagon packetizer case, it seems like there's more debate over whether there's really a "bug" and how it could be "fixed".

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111397/new/

https://reviews.llvm.org/D111397