[PATCH] D111871: [ELF] Let sections reach the end of the address space

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 18 00:36:35 PDT 2021


jhenderson added a comment.

Please upload diffs with full context (create them with something like `-U999999`), as this makes things easier to review, usually (in this case, I think it's clear-cut enough in the context, so don't fret about it, just useful in teh more general case).

I think we need a test case for an empty section at the end of the address space? Similarly, I think we might need test cases that show the error is emitted when the size is just overflowed (i.e. by 1) - I haven't checked what the current state of the test coverage here is.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111871/new/

https://reviews.llvm.org/D111871



More information about the llvm-commits mailing list