[PATCH] D109762: [NewPM][SimpleLoopUnswitch] Add DivergenceInfo

Sameer Sahasrabuddhe via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Oct 17 20:56:32 PDT 2021


sameerds added a comment.

In D109762#3059988 <https://reviews.llvm.org/D109762#3059988>, @aeubanks wrote:

> I talked to some people and we've decided that the best thing to do would be to refactor out the nontrivial unswitching part into a function pass. Nontrivial unswitching is fairly special in the kinds of transforms it does.

Will that always work as expected? The real dependency is that the divergence analysis is not incrementally updated. So even if this is a function pass, we may want to rerun it on the whole function every time it manages to unswitch a loop.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109762/new/

https://reviews.llvm.org/D109762



More information about the llvm-commits mailing list