[PATCH] D111699: [XCOFF] [llvm-readobj] replace tests using binary as input with tests generated by yaml2obj.

[Esme Yi via Phabricator via llvm-commits]

Esme added inline comments.


================
Comment at: llvm/test/tools/llvm-readobj/XCOFF/file-header.test:20-23
+FileHeader:
+  MagicNumber:          [[MAGIC=0x01DF]]
+  CreationTime:         [[CREATTIME=0]]
+  EntriesInSymbolTable: [[SYMBOLCOUNT=0]]
----------------
jhenderson wrote:
> The previous version of this test had non zero values for the fields. I think it's important we do the same, because a 0 value could indicate an unset value in the tool code, rather than a value that has been read.
> 
> There should probably be a special case for 0 for some fields, where 0 has a special meaning (I'm looking at the TimeStamp specifically).
Set non-zero values for all fields (except for the aux file header which is not yet supported).


================
Comment at: llvm/test/tools/llvm-readobj/XCOFF/sections.test:13
+# SEC32-NEXT:     Name: .text
+# SEC32-NEXT:     PhysicalAddress: 0x0
+# SEC32-NEXT:     VirtualAddress: 0x0
----------------
jhenderson wrote:
> As with the file headers case, consider setting non-zero values for all the fields, so that we can exercise dumping properly.
Set non-zero values for all fields (except for the line number which is not yet supported) in the second section.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111699/new/

https://reviews.llvm.org/D111699