[PATCH] D111960: [X86][AVX] Prefer VINSERTF128 over VPERM2F128 for 128->256 subvector concatenations
Pengfei Wang via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Sun Oct 17 07:27:22 PDT 2021
pengfei added inline comments.
================
Comment at: llvm/lib/Target/X86/X86InstrFragmentsSIMD.td:1061
+// INSERT_get_vperm2x128_imm xform function: convert insert_subvector index to
+// commuted VPERM2F128/VPERM2I128 imm.
----------------
Nit: one more space.
================
Comment at: llvm/test/CodeGen/X86/pr50823.ll:11-13
+; CHECK-NEXT: vmovups (%rsi), %ymm0
+; CHECK-NEXT: vinsertf128 $1, 32(%rsi), %ymm0, %ymm0
+; CHECK-NEXT: vhaddps %ymm0, %ymm0, %ymm0
----------------
Is this a regression?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D111960/new/
https://reviews.llvm.org/D111960
More information about the llvm-commits
mailing list