[PATCH] D105168: [RISCV] Unify the arch string parsing logic to RISCVISAInfo.

Kito Cheng via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Oct 17 07:21:24 PDT 2021


kito-cheng added inline comments.


================
Comment at: llvm/lib/Support/RISCVISAInfo.cpp:39
+
+static constexpr StringLiteral AllStdExts = "mafdqlcbjtpvn";
+
----------------
kito-cheng wrote:
> craig.topper wrote:
> > 'b' shouldn't be in this list anymore?
> I would prefer to keep that for sync with ISA manual, like other unsupported extension like `J`, `T` and ``N`, we remove `B` from `SupportedExtensions`, so keep this should be harmless.
Oh, and it also used for compute the canonical order for `z*` extensions.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105168/new/

https://reviews.llvm.org/D105168



More information about the llvm-commits mailing list