[PATCH] D111953: [DebugInfo] Expand ability to load 2-byte addresses in dwarf sections

Jack Andersen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Oct 16 14:35:44 PDT 2021


jackoalan created this revision.
jackoalan added a reviewer: echristo.
Herald added subscribers: cmtice, hiraditya.
Herald added a reviewer: jhenderson.
jackoalan requested review of this revision.
Herald added subscribers: llvm-commits, sstefan1, MaskRay.
Herald added a reviewer: jdoerfert.
Herald added a project: LLVM.

Some dwarf loaders in LLVM are hard-coded to only accept 4-byte and 8-byte address sizes. This patch generalizes acceptance into `DWARFContext::isAddressSizeSupported` and provides a common way to generate rejection errors.

The MSP430 target has been given new tests to cover dwarf loading cases that previously failed due to 2-byte addresses.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D111953

Files:
  llvm/include/llvm/DebugInfo/DWARF/DWARFContext.h
  llvm/include/llvm/DebugInfo/DWARF/DWARFDebugRangeList.h
  llvm/lib/DebugInfo/DWARF/DWARFDebugAddr.cpp
  llvm/lib/DebugInfo/DWARF/DWARFDebugArangeSet.cpp
  llvm/lib/DebugInfo/DWARF/DWARFDebugRangeList.cpp
  llvm/lib/DebugInfo/DWARF/DWARFListTable.cpp
  llvm/lib/DebugInfo/DWARF/DWARFUnit.cpp
  llvm/test/DebugInfo/MSP430/cu-ranges.ll
  llvm/test/DebugInfo/MSP430/dwarf-basics-v5.ll
  llvm/test/DebugInfo/MSP430/ranges_always.ll
  llvm/test/tools/llvm-dwarfdump/X86/debug_addr_invalid_addr_size.s
  llvm/test/tools/llvm-dwarfdump/X86/debug_rnglists_invalid.s
  llvm/unittests/DebugInfo/DWARF/DWARFDebugArangeSetTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D111953.380217.patch
Type: text/x-patch
Size: 35076 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20211016/160d5754/attachment.bin>


More information about the llvm-commits mailing list