[PATCH] D111460: [X86][LoopVectorize] "Fix" `X86TTIImpl::getAddressComputationCost()`

Roman Lebedev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Oct 16 05:53:17 PDT 2021


lebedev.ri added a comment.

In D111460#3068289 <https://reviews.llvm.org/D111460#3068289>, @pengfei wrote:

> In D111460#3068279 <https://reviews.llvm.org/D111460#3068279>, @lebedev.ri wrote:
>
>> In D111460#3068276 <https://reviews.llvm.org/D111460#3068276>, @pengfei wrote:
>>
>>> Sorry, I don't think favoring interleaved loads over gather is always correct.
>>
>> Where am i doing that?
>
> Doesn't comments in X86TargetTransformInfo.cpp say this patch is a hack to do that? Or I just understood it the other way around?

It's precisely the other way around.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111460/new/

https://reviews.llvm.org/D111460



More information about the llvm-commits mailing list