[PATCH] D111803: [LLD][TEST] Add a test case for negative addends for R_X86_64_PC32 relocations

Fri Oct 15 16:56:12 PDT 2021

MaskRay accepted this revision.
MaskRay added a comment.
This revision is now accepted and ready to land.

In D111803#3066817 <https://reviews.llvm.org/D111803#3066817>, @gbreynoo wrote:

> As suggested by Maskray I have renamed `x86-64-reloc-32-fpic.s` and added a R_X86_64_32 equivalent of the test. To be consistent `x86-64-reloc-pc32-fpic.s` was also renamed and the new test case added.
> Note that git doesn't appear to detect the renames, it may be best for me to commit the code change and rename separately?

I think that's unnecessary. We already need to look at deleted commits if archaeology on the whole history is needed in the future (likely no for this case).

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111803/new/

https://reviews.llvm.org/D111803