[PATCH] D73861: Added DIBasicType scale/picture_string/digits/sign attribute support.

[Amaury SECHET via Phabricator via llvm-commits]

deadalnix requested changes to this revision.
deadalnix added inline comments.
This revision now requires changes to proceed.
Herald added a subscriber: ormris.


================
Comment at: llvm/include/llvm-c/DebugInfo.h:59
-  LLVMDIFlagBigEndian = 1 << 27,
-  LLVMDIFlagLittleEndian = 1 << 28,
   LLVMDIFlagIndirectVirtualBase = (1 << 2) | (1 << 5),
----------------
These flags must remain, even if deprecated. Adding a comment explaining the situation is however warranted. See LLVMDIFlagFixedEnum for instance.


================
Comment at: llvm/include/llvm-c/DebugInfo.h:685
+                                             LLVMDWARFTypeEncoding Encoding,
+                                             LLVMDIBTFlags Flags);
 
----------------
probinson wrote:
> I believe the backward-compatibility requirements for the C API are very strict, and this does not preserve backward compatibility.
Yes, the C API is used for binding, so changes in ABI can have very dire consequences.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73861/new/

https://reviews.llvm.org/D73861