[PATCH] D111800: [VectorCombine] Add option to only run scalarization transforms.

Fri Oct 15 12:35:46 PDT 2021

fhahn added a comment.

In D111800#3067330 <https://reviews.llvm.org/D111800#3067330>, @spatel wrote:

> 

> I drafted a patch for PR52178 , and I see that we get the first pair folded, but we're stuck on the next pair:

Thanks for putting up that patch! I'll take a closer look in the next few days. Is it possible that we need to add additional instructions to the worklist to catch the earlier cases?

In D111800#3067330 <https://reviews.llvm.org/D111800#3067330>, @spatel wrote:

> I posted the proposed vector-combine change here:
> D111901 <https://reviews.llvm.org/D111901>
>
> But this patch LGTM anyway. We don't want vector-combine to make things harder for LV or SLP. 
> Those passes should have a better view of total costs, so it seems right to have vector-combine only trying its minor changes after the others have run.

Sounds good, happy to iterate on improvements to vector-combine separately :)

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111800/new/

https://reviews.llvm.org/D111800