[PATCH] D109416: getVPMemoryOpCost interface

Roland Froese via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Oct 15 12:15:44 PDT 2021


RolandF added inline comments.


================
Comment at: llvm/include/llvm/Analysis/TargetTransformInfo.h:1121
+  InstructionCost
+  getVPMemoryOpCost(unsigned Opcode, Type *Src, Align Alignment,
+                    unsigned AddressSpace,
----------------
I prefer the downstream name getVariableLengthMemoryOpCost.  I'm not sure
what VP stands for here and it seems like VP is already used in the context of VPlan.  At least explain in the comment.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109416/new/

https://reviews.llvm.org/D109416



More information about the llvm-commits mailing list