[PATCH] D110576: [Demangle] Add support for D programming language

[Luís Ferreira via Phabricator via llvm-commits]

ljmf00 added a comment.

In D110576#3062467 <https://reviews.llvm.org/D110576#3062467>, @rsmith wrote:

> In D110576#3029264 <https://reviews.llvm.org/D110576#3029264>, @Geod24 wrote:
>
>> This is a port of libiberty's D demangler <https://github.com/gcc-mirror/gcc/blob/master/libiberty/d-demangle.c> as some comments mention, which was written by Iain Buclaw <https://github.com/ibuclaw>, the maintainer of GDC (GCC-based D compiler).
>> We have been in frequent communication with him before the project started and he has no issue with this code being used (and re-licensed) by LLVM. If any document / proof is needed on that side, please let us know.
>
> Is the consent of @ibuclaw sufficient? According to github, there have been seven contributors to this code: https://github.com/gcc-mirror/gcc/blob/master/libiberty/d-demangle.c. In addition to @ljmf00 and @ibuclaw, they are: (github usernames) bobsayshilol, jakubjelinek, rainers, brobecke, amodra

A few additions to your comment:

- jakubjelinek: updated copyright headers only (not eligible here)
- the change introduced with brobecke was reverted by ibuclaw on https://github.com/gcc-mirror/gcc/commit/fd91ffb8051c3a99b8fdffa1c6234f9f884fce1c#diff-b3f1a0056a0bc5c69d189e9f60fd8b03c22b08d4343c745e3d914461c646fbc6  (not eligible here)
- changes introduced by rainers was co-authored with ibuclaw (see: https://github.com/gcc-mirror/gcc/commit/3f30a274913bde0a1e01a86ce7c85e3be34ea13f#diff-b3f1a0056a0bc5c69d189e9f60fd8b03c22b08d4343c745e3d914461c646fbc6)
- rainers is part of the D Programming Language organization
- the copyright notice on the file header, only mention `Written by Iain Buclaw (ibuclaw at gdcproject.org)`
- changes introduced by amodra and bobsayshilol was relatively small (avg 50 lines of code, equivalent to 2 to 3% of the code)

Please note that I'm not saying that small contributions are not eligible for relicensing, just stating that fact, for further appreciation, if eligible.



================
Comment at: llvm/lib/Demangle/DLangDemangle.cpp:1862
+                                      bool SuffixModifiers) {
+  /* Qualified names are identifiers separated by their encoded length.
+     Nested functions also encode their argument types without specifying
----------------
MaskRay wrote:
> For a block comment, `//` is preferred as well. https://llvm.org/docs/CodingStandards.html#comment-formatting
I'll address that, however, if find anything more like that, please review on the split patches, please, otherwise I can loose track of it more easily.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110576/new/

https://reviews.llvm.org/D110576