[PATCH] D111891: [Analysis] add utility function for unary shuffle mask creation

Sanjay Patel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Oct 15 08:36:45 PDT 2021


spatel added a comment.

In D111891#3066906 <https://reviews.llvm.org/D111891#3066906>, @tschuett wrote:

> This is personal style! I would hoist the ugly c-style cast out of the loop and avoid the subtraction with mixed signed integers.

Sure - then I can also put another safety assert on that value. The casts were carried over from the SDAG code which has lots of that messiness dealing with shuffle mask values.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111891/new/

https://reviews.llvm.org/D111891



More information about the llvm-commits mailing list