[PATCH] D111852: [lld/mac] Mark private externs with GOT relocs as LOCAL in indirect symbtab

Fri Oct 15 07:40:27 PDT 2021

oontvoo accepted this revision.
oontvoo added inline comments.
This revision is now accepted and ready to land.

================
Comment at: lld/test/MachO/compact-unwind-both-local-and-dylib-personality.s:42-45
+# BC-DAG:  0x[[#%x,GXX_PERSONALITY_HI:]] LOCAL
 # BC-DAG:  0x[[#%x,GXX_PERSONALITY_LO:]] LOCAL
 # BC-DAG:  0x[[#%x,PERSONALITY_1:]]  LOCAL
 # BC-DAG:  0x[[#%x,PERSONALITY_2:]]  LOCAL
----------------
LD64 seems to only produced the three personality that are "picked" here. (ie., GXX_PERSONALITY_HI isn't present).
I guess that's fine?

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111852/new/

https://reviews.llvm.org/D111852