[PATCH] D111288: [fir] Add data flow optimization pass
Mehdi AMINI via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Oct 15 01:49:29 PDT 2021
mehdi_amini added a comment.
> . Perhaps we could make sure that:
>
> - every test is documented (e.g. by making a descriptive function name that highlights "what" is being tested)
> - check lines not strictly related to the functionality being tested are reduced/removed
Right, that seems to go in the direction of the guidelines I posted I think :)
Thanks!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D111288/new/
https://reviews.llvm.org/D111288
More information about the llvm-commits
mailing list