[PATCH] D111768: [IPT] Restructure cache to allow lazy update following invalidation [NFC]

[Max Kazantsev via Phabricator via llvm-commits]

mkazantsev added inline comments.


================
Comment at: llvm/lib/Analysis/InstructionPrecedenceTracking.cpp:96
+    if (&I == It->second)
+      // No special instruction before cached result
       return;
----------------
reames wrote:
> mkazantsev wrote:
> > This loosens the validation. What if  `I` is not special? We used to check this and now we don't.
> We check to see if I is special just below.  And as indicated in the comment, the cached result does not need to be special, just before any special instruction.  
If `I` is not special but it somehow got into the `It->second`, where do you detect that?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111768/new/

https://reviews.llvm.org/D111768