[PATCH] D111337: [fir] Add array value copy pass

[Valentin Clement via Phabricator via llvm-commits]

clementval added a comment.

In D111337#3066029 <https://reviews.llvm.org/D111337#3066029>, @mehdi_amini wrote:

> Without getting into a "100%" coverage mode, this revision is adding a lot of code in `include/flang/Optimizer/Builder/` and separately a pass with what looks like minimal testing. 
> Just looking at the pass itself, there are many so many special cases and handling, but the existing test case seems like just the basic?
> Now the code in the Builder directory is as large as the pass itself, what kind of testing / coverage do we have for that? 
> I wonder if the "array copy value" Pass is really the best way to provide testing for everything else here: could we have some test pass that showcase / exercise more specifically these components for example?
> (for example, some loop utilities in MLIR are tested with a dedicated pass here: https://github.com/llvm/llvm-project/blob/main/mlir/test/lib/Dialect/SCF/TestSCFUtils.cpp )

As you can see in the two previous update on this patch, I'm in thr process of removing code from this patch and create additional smaller patch that can be easily reviewed. This will take some time. I'll let you know when this patch has been shrunk down to a minimal one.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111337/new/

https://reviews.llvm.org/D111337