[PATCH] D111769: [Polly][NFC] Remove checkIslAstExprInt and use RAII instead of manually freeing Expr

Thu Oct 14 19:34:29 PDT 2021

Meinersbur accepted this revision.
Meinersbur added a comment.
This revision is now accepted and ready to land.

LGTM.

Could you update the summary to something that makes sense in a commit message? Yes, you understand correctly.

Would you like me to land this patch for you?

================
Comment at: polly/lib/CodeGen/IslNodeBuilder.cpp:187
   isl::ast_expr UB = getUpperBound(For, Predicate);
   if (isl_ast_expr_get_type(UB.get()) != isl_ast_expr_int)
     return -1;
----------------
InnovativeInventor wrote:
> It looks like I should change this to be `!Expr.isa<isl::ast_expr_int>()` as well, right? If so, should I make a different review or do you want each patch to be tightly scoped and not contain a hodgepodge of changes?
I assume this was a comment to an earlier revision and you meant `UB.isa<...` as it is in the current iteration. 

Looks god as-is.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111769/new/

https://reviews.llvm.org/D111769