[PATCH] D88741: [SystemZ/z/OS] Add utility class for char set conversion.

[Zarko Todorovski via Phabricator via llvm-commits]

ZarkoCA added inline comments.


================
Comment at: llvm/include/llvm/Support/CharSet.h:32
+namespace text_encoding {
+enum class id {
+  /// UTF-8 character set encoding.
----------------
I think enums should start with an uppercase letter as per the style guide.


================
Comment at: llvm/include/llvm/Support/CharSet.h:42
+};
+}
+
----------------
nit: may be more clear to add the ending comment.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88741/new/

https://reviews.llvm.org/D88741