[PATCH] D111852: [lld/mac] Mark private externs with GOT relocs as LOCAL in indirect symbtab

[Vy Nguyen via Phabricator via llvm-commits]

oontvoo added a comment.

In D111852#3065697 <https://reviews.llvm.org/D111852#3065697>, @thakis wrote:

> Looking at https://reviews.llvm.org/D107533, apparently we just ignore the symbol in UnwindInfoSection.cpp and pick a different one, but still write the old one in the symbol table. That looks pretty sketch :/

It is absolutely sketchy as I was trying to imitate LD64's behaviour, which we'd agreed was inconsistent. The only reason I put it in was because it unbroke a **lot** of Chromium/Cronet based tests and it seemed fairly harmless to others at the time.

TBH, I've been pondering removing it - esp. jyknight@ has suggested a different solution (ie., removing chrome personality function - see the email he sent a month ago ...)

If it's blocking you, we could remove it now?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111852/new/

https://reviews.llvm.org/D111852