[PATCH] D111687: Fix getInlineCost with ComputeFullInlineCost enabled
Wenlei He via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Oct 14 15:54:41 PDT 2021
wenlei added a comment.
Thanks for the fix!
> We ran across this issue with a downstream user of InlineCost. I found that upstream SampleProfile uses getInlineCost with ComputeFullInlineCost, so I added a test case demonstrating the issue via SampleProfile.
Yeah, SampleProfile is interested in the cost only as it uses its own threshold based on profiles (we don't rely on the threshold from getInlineCost because profile isn't annotated on IR yet). Actually I added `DecidedByCostBenefit` and it was also for sample profile case.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D111687/new/
https://reviews.llvm.org/D111687
More information about the llvm-commits
mailing list